This repository was archived by the owner on Feb 25, 2025. It is now read-only.
More rename from GPU thread to raster thread#17408
Merged
liyuqian merged 6 commits intoflutter:masterfrom Mar 31, 2020
Merged
Conversation
GPUTaskRunner -> RasterTaskRunner gpu_task_runner -> raster_task_runner
gpu_thread -> raster_thread GpuThread -> RasterThread (These include filename changes)
liyuqian
added
Work in progress (WIP)
liyuqian
force-pushed
the
gpu_raster_rename
branch
from
868a228 to
e760de3
Compare
liyuqian
changed the title
chinmaygarde
approved these changes
Mar 31, 2020
Contributor
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
I marked the outdated comments I noticed. I am sure there are others but we can update those those as we notice them. Let's land this ASAP to prevent merge conflicts for a patch of this surface area.
| // threads are the same, should_post_gpu_task will be false, and then instead | ||
| // of posting a task to the raster thread, the ui thread just signals the | ||
| // latch and the platform/raster thread follows with executing gpu_task. | ||
| bool should_post_gpu_task = task_runners_.GetRasterTaskRunner() != |
| @@ -721,24 +721,24 @@ void Shell::OnPlatformViewDestroyed() { | |||
| // gpu_task to the raster thread triggers signaling the latch(on the IO | |||
| // thread). If the GPU the and platform threads are the same this results in a | |||
Contributor
There was a problem hiding this comment.
This comment uses the old names still.
| // the GPU and platform threads. Reduces the lease term by 1. | ||
| GpuThreadStatus DecrementLease(); | ||
| // Returns |RasterThreadStatus::kUnmergedNow| if this call resulted in | ||
| // splitting the GPU and platform threads. Reduces the lease term by 1. |
Contributor
There was a problem hiding this comment.
Outdated thread name in comment.
| @@ -190,7 +190,7 @@ SceneHost::SceneHost(fml::RefPtr<zircon::dart::Handle> viewHolderToken, | |||
|
|
|||
| // Pass the raw handle to the GPU thead; destroying a |zircon::dart::Handle| | |||
Contributor
There was a problem hiding this comment.
Outdated thread name in comment.
| @@ -117,7 +117,7 @@ Dart_Handle Picture::RasterizeToImage(sk_sp<SkPicture> picture, | |||
|
|
|||
| // Kick things off on the GPU. | |||
Contributor
There was a problem hiding this comment.
"on the raster task runner"
| // and the platform threads are the same, should_post_gpu_task will be false, | ||
| // and then instead of posting a task to the raster thread, the ui thread just | ||
| // signals the latch and the platform/raster thread follows with executing | ||
| // gpu_task. |
cbracken
approved these changes
Mar 31, 2020
Member
cbracken
left a comment
cbracken
left a comment
There was a problem hiding this comment.
Nice -- agreed with Chinmay; you may want to merge sooner rather than later to avoid conflicts, then land a cleanup.
Contributor
Author
|
Thanks! I'll merge this as is to avoid conflict, and address Chinmay's comment in another PR. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 31, 2020
fluttergithubbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 31, 2020
goderbauer
pushed a commit
to goderbauer/engine
that referenced
this pull request
Apr 16, 2020
This PR touches variable names, class names, and file names so it's significantly more risky than its predecessor flutter#17329 Due to file name changes, this PR is expected to change the license files. We haven't rename `shell/gpu` to `shell/raster` yet. It should be optional but I think it's better to have `raster_surface_software.cc` than `gpu_surface_software.cc`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR touches variable names, class names, and file names so it's significantly more risky than its predecessor #17329
Due to file name changes, this PR is expected to change the license files.
We haven't rename
shell/gputoshell/rasteryet. It should be optional but I think it's better to haveraster_surface_software.ccthangpu_surface_software.cc.