This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix iOS builds on Xcode 11.4 for new enum values added in iOS 13.4.#17429
Merged
chinmaygarde merged 1 commit intoflutter:masterfrom Mar 31, 2020
Merged
Fix iOS builds on Xcode 11.4 for new enum values added in iOS 13.4.#17429chinmaygarde merged 1 commit intoflutter:masterfrom
chinmaygarde merged 1 commit intoflutter:masterfrom
Conversation
jason-simmons
approved these changes
Mar 31, 2020
xster
reviewed
Mar 31, 2020
| case UITouchPhaseCancelled: | ||
| return flutter::PointerData::Change::kCancel; | ||
| default: | ||
| // TODO(53695): Handle the `UITouchPhaseRegion`... enum values. |
Member
There was a problem hiding this comment.
Can we print something here? Like unexpected touch phase $phase received. So if we forget anything, we'll get reminded.
Contributor
Author
There was a problem hiding this comment.
We are veering away from the adding logs that the user/developer cannot take action on. I'd prefer we track it via the issue instead.
Contributor
There was a problem hiding this comment.
Maybe just an FML_DLOG(INFO)? That wouldn't show up for normal developers.
Member
|
LGTM |
The following issues have been filed to track the handling of these enum values: * Handle the UITouchTypeIndirectPointer enum value. flutter/flutter#53696 * Handle the UITouchPhaseRegion enum values. flutter/flutter#53695 No change in functionality. Only makes the iOS engine build on the latest versions of Xcode and iOS SDK. The enum values cannot be used with the API_AVAILABLE macro because the buildbots have not been updated yet.
Member
|
LGTM |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 1, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 1, 2020
goderbauer
pushed a commit
to goderbauer/engine
that referenced
this pull request
Apr 16, 2020
…lutter#17429) The following issues have been filed to track the handling of these enum values: * Handle the UITouchTypeIndirectPointer enum value. flutter/flutter#53696 * Handle the UITouchPhaseRegion enum values. flutter/flutter#53695 No change in functionality. Only makes the iOS engine build on the latest versions of Xcode and iOS SDK. The enum values cannot be used with the API_AVAILABLE macro because the buildbots have not been updated yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following issues have been filed to track the handling of these enum values:
UITouchTypeIndirectPointerenum value. Handle the UITouchTypeIndirectPointer enum value. flutter#53696UITouchPhaseRegionenum values. Handle the UITouchPhaseRegion enum values. flutter#53695No change in functionality. Only makes the iOS engine build on the latest
versions of Xcode and iOS SDK. The enum values cannot be used with the
API_AVAILABLEmacro because the buildbots have not been updated yet.