This repository was archived by the owner on Feb 25, 2025. It is now read-only.
If the application says there is a new texture but does not provide one, reuse the last texture.#17437
Merged
chinmaygarde merged 1 commit intoflutter:masterfrom Apr 1, 2020
Conversation
…ne, reuse the last texture. This matches the behavior of the OpenGL backend.
Contributor
Author
|
This may happen with certain plugins that don't anticipate the asynchronous nature of the texture resolution say there is a texture frame ready but don't provide one when asked. This issue only happens with one known plugin and was not caught when I was testing all known applications with Metal earlier because the device I was using was super old and the time it took for Flutter to ask for the texture was long enough that a texture was always ready. The same may fail on newer/faster devices. I have tested all applications on newer devices just to be safe. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 1, 2020
…rovide one, reuse the last texture. (flutter/engine#17437)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 1, 2020
…rovide one, reuse the last texture. (flutter/engine#17437)
goderbauer
pushed a commit
to goderbauer/engine
that referenced
this pull request
Apr 16, 2020
…ne, reuse the last texture. (flutter#17437) This matches the behavior of the OpenGL backend.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This matches the behavior of the OpenGL backend.