This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Conversation
Member
|
LGTM |
dnfield
added a commit
to dnfield/engine
that referenced
this pull request
Apr 1, 2020
…orted symbols (flutter#17440)" (flutter#17451)" This reverts commit a870bc5.
dnfield
added a commit
that referenced
this pull request
Apr 1, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 2, 2020
…ewly exported symbols (flutter#17440)" (flutter/engine#17451)
goderbauer
pushed a commit
to goderbauer/engine
that referenced
this pull request
Apr 16, 2020
…orted symbols (flutter#17440)" (flutter#17451) This reverts commit 8d723ae.
goderbauer
pushed a commit
to goderbauer/engine
that referenced
this pull request
Apr 16, 2020
* Reland "Roll Clang to v11, roll buildroot to fe13f79, allow newly exported symbols (flutter#17440)" (flutter#17451)" This reverts commit a870bc5. * skip golden that is different on macos * buildroot to 1bc40a5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #17440
This broke Xcode bitcode builds - needs a couple more tweaks to buildroot and shoul dbe good. Failing build example here: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket.appspot.com/8884199962162400000/+/steps/build_ios_profile/0/stdout
Will land TBR @chinmaygarde @goderbauer