[fuchsia] Log unregistered platform channels only once#18064
[fuchsia] Log unregistered platform channels only once#18064iskakaushik merged 1 commit intoflutter:masterfrom
Conversation
| FML_LOG(ERROR) | ||
| << "Platform view received message on channel '" << message->channel() | ||
| << "' with no registered handler. And empty response will be " | ||
| "generated. Please implement the native message handler."; |
There was a problem hiding this comment.
Just mention that this message will only be logged once.
This is to reduce log spam. Fixes: flutter/flutter#55966
iskakaushik
added
the
waiting for tree to go green
| << "Platform view received message on channel '" << message->channel() | ||
| << "' with no registered handler. And empty response will be " | ||
| "generated. Please implement the native message handler."; | ||
| const bool already_errored = unregistered_channels_.count(channel); |
There was a problem hiding this comment.
why do we need this additional check? if we're not in unregistered_channels_ then we've never logged before. This currently will log if we get a message on e.g. channelA, then channelB, channelC, etc won't log (as count() will be > 0).
There was a problem hiding this comment.
This is count(channel), as in a count to check if the channel is in the set.
| // These are the channels that aren't registered and have been notified as | ||
| // such. Notifying via logs multiple times results in log-spam. See: | ||
| // https://github.com/flutter/flutter/issues/55966 | ||
| std::set<std::string /* channel */> unregistered_channels_; |
There was a problem hiding this comment.
can we have multiple PlatformViews over the lifetime of a process? do we want this to be a static?
There was a problem hiding this comment.
There's only one platform view per engine so I think that should be fine. Given that what we are seeing now, it this message being printed at error levels every time we receive a platform message on the same channel, I changed it to be INFO and made it so that we log a channel once per engine. So I think this should reduce the problem by a lot. If we notice that we are still seeing spammy behavior making this a static is something we could consider.
4 participants
This is to reduce log spam.
Fixes: flutter/flutter#55966