This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Adding profile parameter to firefox#18792
Merged
nturgut merged 2 commits intoflutter:masterfrom Jun 4, 2020
Merged
Conversation
yjbanov
approved these changes
Jun 3, 2020
lib/web_ui/dev/firefox.dart
Outdated
| // https://developer.mozilla.org/en-US/docs/Mozilla/Command_Line_Options#Browser | ||
| // | ||
| var dir = createTempDir(); | ||
| File(path.join(dir, 'prefs.js')).writeAsStringSync(_profile); |
Contributor
There was a problem hiding this comment.
Should we clean up the profile directory between test runs?
Contributor
Author
There was a problem hiding this comment.
We delete the directory after processExits:
Line 78: unawaited(process.exitCode
.then((_) => Directory(dir).deleteSync(recursive: true)));
Contributor
Author
|
This fix is related to Firefox, which only runs on Linux Web Engine luci bot. Merging the PR since the test failures are not related to the code path. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firefox sometimes gives a popup related to "corrupt profile" and asks if a new profile should be created (happened on local Mac). This might create a flake in the future on LUCI bots
In order to prevent these type of popups give a profile when opening firefox. Preferences are taken from: https://github.com/dart-lang/test/blob/master/pkgs/test/lib/src/runner/browser/firefox.dart