This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Enable ios platform view by default#20671
Merged
fluttergithubbot merged 3 commits intoflutter:masterfrom Aug 21, 2020
Merged
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
blasten
reviewed
Aug 20, 2020
| @@ -76,11 +67,7 @@ bool IsIosEmbeddedViewsPreviewEnabled() { | |||
| } | |||
|
|
|||
| ExternalViewEmbedder* IOSSurface::GetExternalViewEmbedderIfEnabled() { | |||
There was a problem hiding this comment.
nit: should we just remove GetExternalViewEmbedderIfEnabled?
Contributor
Author
There was a problem hiding this comment.
This is the common method that's called by all the different surface implementations. So it is better to keep it there. Or we can update the method name (removing the IfEnabled)?
There was a problem hiding this comment.
Yup. GetExternalViewEmbedder mirrors Android's.
cyanglaz
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 21, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 21, 2020
13 tasks
This was referenced Oct 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
An app that uses platform view (webview, googlemap, etc) doesn't need to add the
io.flutter.embedded_views_previewflag on their info.plist after this patch lands.Related Issues
Fixes flutter/flutter#64270
Tests
I added the following tests:
Updated the scenario app to not include the flag and the tests should still pass
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.Breaking Change
Did any tests fail when you ran them? Please read handling breaking changes.