This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Account for current open image in FlutterImageView#21191
Merged
blasten merged 2 commits intoflutter:masterfrom Sep 15, 2020
Merged
Account for current open image in FlutterImageView#21191blasten merged 2 commits intoflutter:masterfrom
blasten merged 2 commits intoflutter:masterfrom
Conversation
jason-simmons
approved these changes
Sep 15, 2020
blasten
added
the
waiting for tree to go green
pcsosinski
pushed a commit
to pcsosinski/engine
that referenced
this pull request
Sep 15, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 15, 2020
pcsosinski
pushed a commit
that referenced
this pull request
Sep 15, 2020
* Update 1.22 engine to use Dart 2.10.0-110.3.beta * Add a new raster status `kSkipAndRetry` frame (#21059) * update license file for Dart 2.10.0-110.3.beta * Account for current open image in FlutterImageView (#21191) Co-authored-by: Emmanuel Garcia <[email protected]>
|
Any further update? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
My previous patch didn't account for the fact that the image remains open after it's dequeued, so there's a bug in the current implementation. I updated the test to account for this case.
Related Issues
Fixes flutter/flutter#63897
Tests
Unit test
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.Breaking Change
Did any tests fail when you ran them? Please read handling breaking changes.