Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Re-enable ShellTest.SkipAndSubmitFrame#22546

Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom
cyanglaz:external_view_embedder_test_flake
Nov 17, 2020
Merged

Re-enable ShellTest.SkipAndSubmitFrame#22546
fluttergithubbot merged 1 commit intoflutter:masterfrom
cyanglaz:external_view_embedder_test_flake

Conversation

@cyanglaz
Copy link
Contributor

@cyanglaz cyanglaz commented Nov 16, 2020

Description

With this patch, I ran the tests about 600 iterations and didn't get a failure.
Note: I don't have a linux machine and I ran the tests on my mac.

Related Issues

Fixes flutter/flutter#66056

Tests

I added the following tests:

ShellTest.SkipAndSubmitFrame

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the contributor guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the C++, Objective-C, Java style guides for the engine.
  • I read the tree hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation.
  • All existing and new tests are passing.
  • I am willing to follow-up on review comments in a timely manner.

Reviewer Checklist

Breaking Change

Did any tests fail when you ran them? Please read handling breaking changes.

@blasten
Copy link

blasten commented Nov 16, 2020

Note: I don't have a linux machine and I ran the tests on my mac.

you could get a cloudtop

@cyanglaz
Copy link
Contributor Author

I tested on cloudtop linux machine and it was passing for 60k times. I'm going to land this and if ci breaks again, we will re-disable the test.

@cyanglaz cyanglaz added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Nov 17, 2020
@fluttergithubbot fluttergithubbot merged commit 2c2e3a2 into flutter:master Nov 17, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 17, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 17, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 17, 2020
chaselatta pushed a commit to chaselatta/engine that referenced this pull request Nov 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ShellTest.SkipAndSubmitFrame is flaky

4 participants