Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

fix video(texture) with opacity can not play issue#23793

Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom
zljj0818:master-opacity-video-issue
Jan 26, 2021
Merged

fix video(texture) with opacity can not play issue#23793
fluttergithubbot merged 1 commit intoflutter:masterfrom
zljj0818:master-opacity-video-issue

Conversation

@zljj0818
Copy link
Contributor

@zljj0818 zljj0818 commented Jan 20, 2021 •
edited
Loading

If video is child of Opacity widget, it cannot play, for it generate layer cache. So ConainerLayer should not generate layer cache if has texture layer, just like PlatformViewLayer.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

flutter-dashboard bot commented Jan 20, 2021

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@zljj0818
Copy link
Contributor Author

zljj0818 commented Jan 20, 2021 •
edited
Loading

Can reproduce this issue use gallery demo in https://github.com/zljj0818/flutter/tree/master-opacity-video-issue.
image

@zljj0818
Copy link
Contributor Author

zljj0818 commented Jan 22, 2021 •
edited
Loading

Hi, how can i retrigger the checks?

@zljj0818 zljj0818 force-pushed the master-opacity-video-issue branch from aaf2b61 to ba5fbd3 Compare January 26, 2021 01:12
@zljj0818
Copy link
Contributor Author

zljj0818 commented Jan 26, 2021

@chinmaygarde All checks passed, please review PR again

@chinmaygarde chinmaygarde added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jan 26, 2021
@fluttergithubbot fluttergithubbot merged commit 7c8d037 into flutter:master Jan 26, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 26, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 26, 2021
@engine-flutter-autoroll
7c8d037 fix video(texture) with opacity can not play issue (flutter/e…
4ccee6a 
…ngine#23793)
hjfreyer pushed a commit to hjfreyer/engine that referenced this pull request Mar 22, 2021
@zljj0818 @hjfreyer
fix video(texture) with opacity can not play issue (flutter#23793)
396c7be
@flar
Copy link
Contributor

flar commented May 4, 2022

Is there a bug here? Look at the way the has_platform flag is maintained in ContainerLayer::PrerollChildren and compare to how the has_texture flag is managed. There are some missing steps that would mean that any child that has a texture layer would set the flag for siblings and potentially cousins.

The flag in the context needs to be reset on every child that is processed, just as the platform flag is reset.

@flar flar mentioned this pull request May 4, 2022
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@chinmaygarde chinmaygarde chinmaygarde approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zljj0818 @flar @chinmaygarde @googlebot @fluttergithubbot