This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Wrap all the contents of the glass-pane in a shadow root.#25483
Closed
ditman wants to merge 14 commits intoflutter:masterfrom
ditman:platform-views-in-slots
Closed
[web] Wrap all the contents of the glass-pane in a shadow root.#25483ditman wants to merge 14 commits intoflutter:masterfrom ditman:platform-views-in-slots
ditman wants to merge 14 commits intoflutter:masterfrom
ditman:platform-views-in-slots
Conversation
yjbanov
reviewed
Apr 13, 2021
| // found in the LICENSE file. | ||
|
|
||
| // @dart = 2.6 | ||
| // @dart = 2.9 |
Contributor
There was a problem hiding this comment.
Should this be 2.12 at this point?
Member
Author
There was a problem hiding this comment.
2.12 only if we migrate the test to null-safety, which this is not doing yet :P
ditman
changed the title
Member
Author
|
I just realized that I regressed rendering the RulerHosts into the new ShadowDOM. Oops. |
6 tasks
…w root from domRenderer.
…ne when the domRenderer is initializing.
9 tasks
Member
Author
|
Continued in #25747 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a WIP review, just to trigger CI and see all the breakage that a change like this would cause.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.