Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fix html version of drawImageNine#25605

Merged
flar merged 3 commits intoflutter:masterfrom
flar:fix-html-nine-slice-images
Apr 28, 2021
Merged

Fix html version of drawImageNine#25605
flar merged 3 commits intoflutter:masterfrom
flar:fix-html-nine-slice-images

Conversation

@flar
Copy link
Contributor

@flar flar commented Apr 15, 2021

@flar flar requested a review from yjbanov April 15, 2021 04:01
@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Apr 15, 2021
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if LGT @ferhatb

Copy link
Contributor

@ferhatb ferhatb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much cleaner.

@flar flar force-pushed the fix-html-nine-slice-images branch from 3f7f0da to f0a5f46 Compare April 17, 2021 00:36
@flar flar added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Apr 26, 2021
@flar flar removed the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Apr 26, 2021
@flar flar force-pushed the fix-html-nine-slice-images branch from f0a5f46 to d3d96df Compare April 26, 2021 20:45
@flar flar merged commit d0688da into flutter:master Apr 28, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 28, 2021
fluttergithubbot pushed a commit to flutter/flutter that referenced this pull request Apr 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes platform-web Code specifically for the web engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

html web-renderer incorrectly renders nine-slice images with an empty center region

3 participants