This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Manual SDK roll for DevTools SDK integration#26075
Merged
fluttergithubbot merged 2 commits intomasterfrom May 11, 2021
Merged
Conversation
aam
approved these changes
May 11, 2021
bkonyi
added
the
waiting for tree to go green
Member
|
In the future, please coordinate with the Engine sheriff when landing a manual roll while the autoroller is stopped |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 12, 2021
8 tasks
cbracken
added a commit
to cbracken/flutter
that referenced
this pull request
May 12, 2021
flutter/engine@3c93ad4...44ba0c7 2021-05-11 [email protected] Formatting cleanup for CONTRIBUTING.md (flutter/engine#26080) 2021-05-11 [email protected] Add uwptool.exe (flutter/engine#26038) 2021-05-11 [email protected] Manual SDK roll for DevTools SDK integration (flutter/engine#26075) 2021-05-11 [email protected] Roll Skia from 96bc12d19b9e to 7c328b4b42c5 (5 revisions) (flutter/engine#26071) 2021-05-11 [email protected] Unique frame number for each frame (flutter/engine#26021) In flutter/engine#26075 we rolled the Dart SDK to the engine. This included updates to parameter names to Iterable.map and Iterable.expand which triggers lints about renaming method parameters in CachingIterable.map and CachingIterable.expand.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 12, 2021
cbracken
added a commit
to flutter/flutter
that referenced
this pull request
May 12, 2021
flutter/engine@3c93ad4...44ba0c7 2021-05-11 [email protected] Formatting cleanup for CONTRIBUTING.md (flutter/engine#26080) 2021-05-11 [email protected] Add uwptool.exe (flutter/engine#26038) 2021-05-11 [email protected] Manual SDK roll for DevTools SDK integration (flutter/engine#26075) 2021-05-11 [email protected] Roll Skia from 96bc12d19b9e to 7c328b4b42c5 (5 revisions) (flutter/engine#26071) 2021-05-11 [email protected] Unique frame number for each frame (flutter/engine#26021) In flutter/engine#26075 we rolled the Dart SDK to the engine. This included updates to parameter names to Iterable.map and Iterable.expand which triggers lints about renaming method parameters in CachingIterable.map and CachingIterable.expand.
naudzghebre
pushed a commit
to naudzghebre/engine
that referenced
this pull request
May 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required adding a CIPD dependency for DevTools.