Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Web: add support for TextInputType.none#26573

Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom
jpnurmi:web-text-input-type-none
Jun 18, 2021
Merged

Web: add support for TextInputType.none#26573
fluttergithubbot merged 1 commit intoflutter:masterfrom
jpnurmi:web-text-input-type-none

Conversation

@jpnurmi
Copy link
Member

@jpnurmi jpnurmi commented Jun 3, 2021 •
edited
Loading

TextInputType.none makes it possible to disable the virtual keyboard for certain TextFields, and lays the foundations for custom in-app virtual keyboards (flutter/flutter#76072).

Ref: flutter/flutter#83567

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jpnurmi
Web: add support for TextInputType.none
8ae2905 
TextInputType.none makes it possible to disable the virtual keyboard
for certain TextFields, and lays the foundations for custom in-app
virtual keyboards (flutter/flutter#76072).

Ref: flutter/flutter#83567
@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Jun 3, 2021
@google-cla google-cla bot added the cla: yes label Jun 3, 2021
@jpnurmi
Copy link
Member Author

jpnurmi commented Jun 3, 2021

A minimal example at https://jpnurmi.kapsi.fi/text-input-type-none/#/

text-input-type-none.mp4

@jpnurmi jpnurmi mentioned this pull request Jun 3, 2021
Merged
8 tasks
jpnurmi
jpnurmi commented Jun 3, 2021
View reviewed changes
mdebbar
mdebbar approved these changes Jun 3, 2021
View reviewed changes
Copy link
Contributor

@mdebbar mdebbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jpnurmi jpnurmi mentioned this pull request Jun 4, 2021
Merged
14 tasks
@mdebbar mdebbar added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jun 17, 2021
@fluttergithubbot fluttergithubbot merged commit a088dc6 into flutter:master Jun 18, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 18, 2021
@engine-flutter-autoroll
a088dc6 Web: add support for TextInputType.none (flutter/engine#26573)
9377f0c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 20, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 20, 2021
@engine-flutter-autoroll
a088dc6 Web: add support for TextInputType.none (flutter/engine#26573)
fd2acef
wqyfavor pushed a commit to wqyfavor/engine that referenced this pull request Jun 21, 2021
@jpnurmi
Web: add support for TextInputType.none (flutter#26573)
46c951b
moffatman pushed a commit to moffatman/engine that referenced this pull request Aug 5, 2021
@jpnurmi @moffatman
Web: add support for TextInputType.none (flutter#26573)
d0f748e
naudzghebre pushed a commit to naudzghebre/engine that referenced this pull request Sep 2, 2021
@jpnurmi
Web: add support for TextInputType.none (flutter#26573)
f90c5be
@jpnurmi jpnurmi deleted the web-text-input-type-none branch April 13, 2022 06:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mdebbar mdebbar mdebbar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes platform-web Code specifically for the web engine waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jpnurmi @mdebbar @fluttergithubbot