This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Reassign content to temporary slot so Safari can delete it.#27154
Merged
fluttergithubbot merged 2 commits intoflutter:masterfrom Jul 7, 2021
ditman:safely-remove-slotted-content-safari-workaround
Merged
[web] Reassign content to temporary slot so Safari can delete it.#27154fluttergithubbot merged 2 commits intoflutter:masterfrom ditman:safely-remove-slotted-content-safari-workaround
fluttergithubbot merged 2 commits intoflutter:masterfrom
ditman:safely-remove-slotted-content-safari-workaround
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
flutter-dashboard
bot
added
platform-web
Member
Author
|
The current unit tests should already cover this new code. Here's the test, and here's the test running in Safari (I think?). |
…te it from the DOM.
ditman
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 7, 2021
moffatman
pushed a commit
to moffatman/engine
that referenced
this pull request
Aug 5, 2021
naudzghebre
pushed a commit
to naudzghebre/engine
that referenced
this pull request
Sep 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This small tweak is required to workaround a Safari issue that will make a Flutter web app's flt-glass-pane lose its layout after removing slotted content after its slot has been removed.
This code just creates a slot at the moment that some slotted content needs to be removed, reassigns said content to that new "tombstone" slot, and then deletes BOTH from the DOM in the same tick.
This seems to not trigger the Safari bug.
Issues
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.