Windows: Implement GetPreferredLanguages for UWP and support l18n by moko256 · Pull Request #27311 · flutter/engine

moko256 · 2021-07-11T06:03:20Z

It implements GetPreferredLanguages for winuwp platform and replace the stub, and support l18n on UWP.
Test on both windows and winuwp for GetPreferredLanguages already exists in master branch.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the CLA.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

flutter-dashboard · 2021-07-11T06:03:22Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

chinmaygarde

I am not familar with this subsystem but I took a stab at reviewing this since there weren't any other takers. A couple of clarifications and nits but other LGTM.

chinmaygarde · 2021-07-22T20:15:21Z

shell/platform/windows/system_utils_winuwp.cc


 #include <sstream>

+#include <third_party/cppwinrt/generated/winrt/Windows.Foundation.Collections.h>


Nit: This is not a system header. Please use use quotes instead of angle brackets to include these.

chinmaygarde · 2021-07-22T20:17:12Z

shell/platform/windows/system_utils_winuwp.cc

-
+  auto platform_langueages = winrt::Windows::System::UserProfile::
+      GlobalizationPreferences::Languages();
+  for (auto platform_language : platform_langueages) {


Does GlobalizationPreferences::Languages need some form of error handling?

Nit: const auto& platform_language

The document GlobalizationPreferences::Languages doesn't say that this function throw any errors, so I think I don't have to handle errors here.

done

moko256 · 2021-07-23T00:48:35Z

Thank you @chinmaygarde for your reviewing. I fix them.

chinmaygarde · 2021-07-23T20:08:22Z

Sorry, one last thing, can this be rebased on ToT please? The presubmits are failing because the commit you built on it too old.

moko256 · 2021-07-23T23:40:52Z

done

chinmaygarde · 2021-07-23T23:41:49Z

Thanks so much!

…l18n (flutter/engine#27311)

…l18n (flutter/engine#27311) (#86976)

thecalamiity · 2021-07-24T07:03:23Z

shell/platform/windows/system_utils_winuwp.cc

-  languages.push_back(L"en-US");
-  languages.push_back(L"en");
-
+  auto platform_langueages = winrt::Windows::System::UserProfile::


You misspelled languages here

Sorry. I'm little busy now so I'll fix it with new PR by tomorrow.

…7763)

…utter#27311)

flutter-dashboard bot added platform-windows needs tests labels Jul 11, 2021

google-cla bot added the cla: yes label Jul 11, 2021

chinmaygarde reviewed Jul 22, 2021

View reviewed changes

chinmaygarde approved these changes Jul 23, 2021

View reviewed changes

moko256 added 2 commits July 24, 2021 07:59

UWP implementation for GetPreferredLanguages

716a691

Fix format for include, for-loop.

5f4cdf7

moko256 force-pushed the moko256_uwp_get_preffered_languages branch from b6aef71 to 5f4cdf7 Compare July 23, 2021 23:00

chinmaygarde merged commit 77710c5 into flutter:master Jul 23, 2021

engine-flutter-autoroll mentioned this pull request Jul 24, 2021

Roll Engine from 522a8e298d68 to 77710c5e806b (1 revision) flutter/flutter#86976

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 24, 2021

77710c5 Windows: Implement GetPreferredLanguages for UWP and support …

afe802d

…l18n (flutter/engine#27311)

fluttergithubbot pushed a commit to flutter/flutter that referenced this pull request Jul 24, 2021

77710c5 Windows: Implement GetPreferredLanguages for UWP and support …

f802cd6

…l18n (flutter/engine#27311) (#86976)

thecalamiity reviewed Jul 24, 2021

View reviewed changes

moko256 added a commit to moko256/flutter_engine that referenced this pull request Jul 24, 2021

fix a typo in flutter#27311

185a919

moko256 mentioned this pull request Jul 24, 2021

Fix a typo in https://github.com/flutter/engine/pull/27311 #27687

Merged

8 tasks

fluttergithubbot pushed a commit that referenced this pull request Aug 5, 2021

fix a typo in #27311 (#27687)

c0e59bc

engine-flutter-autoroll mentioned this pull request Aug 5, 2021

Roll Engine from 431ac604da1b to c0e59bc7b65e (1 revision) flutter/flutter#87757

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 5, 2021

c0e59bc fix a typo in flutter/engine#27311 (flutter/engine#27687)

9f17f45

engine-flutter-autoroll mentioned this pull request Aug 6, 2021

Roll Engine from 431ac604da1b to c0e59bc7b65e (1 revision) flutter/flutter#87763

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 6, 2021

c0e59bc fix a typo in flutter/engine#27311 (flutter/engine#27687)

0ce5f55

fluttergithubbot pushed a commit to flutter/flutter that referenced this pull request Aug 6, 2021

c0e59bc fix a typo in flutter/engine#27311 (flutter/engine#27687) (#8…

a694778

…7763)

xster mentioned this pull request Aug 23, 2021

20% graphics memory increase in latest roll flutter/flutter#88745

Closed

naudzghebre pushed a commit to naudzghebre/engine that referenced this pull request Sep 2, 2021

Windows: Implement GetPreferredLanguages for UWP and support l18n (fl…

f7b11e1

…utter#27311)

filmil pushed a commit to filmil/engine that referenced this pull request Apr 21, 2022

fix a typo in flutter#27311 (flutter#27687)

9ee506a


		#include <sstream>

		#include <third_party/cppwinrt/generated/winrt/Windows.Foundation.Collections.h>

Conversation

moko256 commented Jul 11, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Jul 11, 2021

Uh oh!

chinmaygarde left a comment

Choose a reason for hiding this comment

Uh oh!

chinmaygarde Jul 22, 2021

Choose a reason for hiding this comment

Uh oh!

moko256 Jul 23, 2021

Choose a reason for hiding this comment

Uh oh!

chinmaygarde Jul 22, 2021

Choose a reason for hiding this comment

Uh oh!

chinmaygarde Jul 22, 2021

Choose a reason for hiding this comment

Uh oh!

moko256 Jul 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

moko256 commented Jul 23, 2021

Uh oh!

chinmaygarde commented Jul 23, 2021

Uh oh!

moko256 commented Jul 23, 2021

Uh oh!

chinmaygarde commented Jul 23, 2021

Uh oh!

thecalamiity Jul 24, 2021

Choose a reason for hiding this comment

Uh oh!

moko256 Jul 24, 2021

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

moko256 commented Jul 11, 2021 •

edited

Loading

moko256 Jul 23, 2021 •

edited

Loading