This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "Build dart:zircon and dart:zircon_ffi (#28071)"#28313
Merged
cbracken merged 1 commit intoflutter:masterfrom Aug 26, 2021
cbracken:revert-zircon-ffi
Merged
Revert "Build dart:zircon and dart:zircon_ffi (#28071)"#28313cbracken merged 1 commit intoflutter:masterfrom cbracken:revert-zircon-ffi
cbracken merged 1 commit intoflutter:masterfrom
cbracken:revert-zircon-ffi
Conversation
This reverts commit fa05362. Reverting in order to land revert of the gn script_executable from python3 to vpython3, which is causing flakes on Windows. Issue: flutter/flutter#88719
cbracken
added
waiting for tree to go green
Member
Author
|
Holding off on landing until we see if #28314 is sufficient to fix the flakiness on Windows. |
8 tasks
cbracken
added a commit
that referenced
this pull request
Aug 26, 2021
Picks up a revert of a change from using python3 to vpython3 for exec rules in gn. flutter/buildroot#507 Also sets Python runtime to `python3` in `gn.bat` to match the revert to `python3` in #28313 Issue: flutter/flutter#88719
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit fa05362.
Reverting in order to land revert of the gn script_executable from
python3 to vpython3, which is causing flakes on Windows. This revert is
required because the original patch introduced a dependency on the
yamlmodule, which ships with
vpython3but not as part of the CIPD packagethat includes
python3.Issue: flutter/flutter#88719
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.