Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[UWP] Add modifier keys support#28724

Merged
cbracken merged 2 commits intoflutter:masterfrom
moko256:moko256_uwp_key_channel_handler
Sep 27, 2021
Merged

[UWP] Add modifier keys support#28724
cbracken merged 2 commits intoflutter:masterfrom
moko256:moko256_uwp_key_channel_handler

Conversation

@moko256
Copy link
Contributor

@moko256 moko256 commented Sep 20, 2021 •
edited
Loading

This PR adds modifier keys support by implementing GetModsForKeyState() in keyboard_key_channel_handler.cc.

This PR will fix flutter/flutter#82440.
This PR will complete one item in flutter/flutter#70202.

No changes in flutter/tests.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@flutter-dashboard
Copy link

flutter-dashboard bot commented Sep 20, 2021

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label Sep 20, 2021
cbracken
cbracken approved these changes Sep 27, 2021
View reviewed changes
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks for fixing this!

LGTM stamp from a Japanese personal seal

@clarkezone it would be nice for us to kill off a bunch of the remaining #ifdef WINUWP blocks in our code by refactoring the embedder-specific code into separate translation units that we can pull in via the build file. I've filed flutter/flutter#90818 for this.

@cbracken cbracken merged commit 9dbdc93 into flutter:master Sep 27, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 27, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 27, 2021
@engine-flutter-autoroll
9dbdc93 [UWP] Add modifier keys support (flutter/engine#28724)
50c52b7
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dkwingsmt dkwingsmt Awaiting requested review from dkwingsmt

@clarkezone clarkezone Awaiting requested review from clarkezone

1 more reviewer

@cbracken cbracken cbracken approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes needs tests platform-windows

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

UWP: Pressing ctrl key causes a native exception

2 participants

@moko256 @cbracken