This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Merged
Conversation
godofredoc
approved these changes
Sep 20, 2021
Contributor
godofredoc
left a comment
godofredoc
left a comment
There was a problem hiding this comment.
I retried the Cirrus task. LGTM if it passes.
Contributor
Author
|
This looks like it will pass Cirrus on the rerun. I'm going to land it on red to help the tree get green. |
Contributor
Author
|
(once cirrus is done that is) |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 20, 2021
akbiggs
pushed a commit
to akbiggs/engine
that referenced
this pull request
Sep 21, 2021
xster
pushed a commit
to xster/engine
that referenced
this pull request
Sep 30, 2021
xster
added a commit
that referenced
this pull request
Oct 4, 2021
Ignoring the web framework test since the failure originates from a repo synchronization issue between engine and framework. The new failing tests were sync'ed in from head in the test and the tested code doesn't exist in the engine at the time of branch cut. * Fixes FlutterSemanticsScrollView to not implement accessibility container API (#28846) * add branch to test * Replace jcenter() for mavenCentral() (#28777) * Set MinimumOSVersion to iOS 9 in Info.plist (#28783) * Do not use jcenter(), switch to mavenCentral() (#28738) Co-authored-by: chunhtai <[email protected]> Co-authored-by: Emmanuel Garcia <[email protected]> Co-authored-by: Jenn Magder <[email protected]> Co-authored-by: Dan Field <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jcenter is deprecated, switch to mavenCentral.