Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Roll Chrome to major version 96#28990

Merged
harryterkelsen merged 5 commits intoflutter:masterfrom
harryterkelsen:roll-chrome
Oct 5, 2021
Merged

Roll Chrome to major version 96#28990
harryterkelsen merged 5 commits intoflutter:masterfrom
harryterkelsen:roll-chrome

Conversation

@harryterkelsen
Copy link
Contributor

@harryterkelsen harryterkelsen commented Oct 2, 2021

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Oct 2, 2021
@google-cla google-cla bot added the cla: yes label Oct 2, 2021
@harryterkelsen harryterkelsen requested a review from yjbanov October 2, 2021 00:04
yjbanov
yjbanov approved these changes Oct 5, 2021
View reviewed changes
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@harryterkelsen harryterkelsen requested a review from yjbanov October 5, 2021 19:56
@harryterkelsen harryterkelsen merged commit ad45b1c into flutter:master Oct 5, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 5, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 5, 2021
@engine-flutter-autoroll
ad45b1c Roll Chrome to major version 96 (flutter/engine#28990)
23a0b12
dnfield pushed a commit to dnfield/engine that referenced this pull request Oct 6, 2021
@dnfield
Roll Chrome to major version 96 (flutter#28990)
fc30995
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@yjbanov yjbanov Awaiting requested review from yjbanov

Assignees

No one assigned

Labels

cla: yes platform-web Code specifically for the web engine

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@harryterkelsen @yjbanov