It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@cbracken About the lack of tests here. It looks like this file fl_text_input_plugin.cc currently has no tests. Is there another way to test this or what's our policy for testing Linux code like this?

I think if I wanted to instantiate FLTextInputPlugin in a test, I would need to create mocks for some classes that don't have any like FLView (constructor, example of where it's called). Seems like a big project so I want to make sure I need to do it before I spend more time on it.

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

Sounds good, thanks for the review. Let me know if you get the test infrastructure in place for this.