Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[iOS text input] do not forward press events to the engine#29464

Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom
LongCatIsLooong:dont-forward-keyevents-to-engine
Nov 2, 2021
Merged

[iOS text input] do not forward press events to the engine#29464
fluttergithubbot merged 1 commit intoflutter:masterfrom
LongCatIsLooong:dont-forward-keyevents-to-engine

Conversation

@LongCatIsLooong
Copy link
Contributor

@LongCatIsLooong LongCatIsLooong commented Nov 2, 2021

Now that the input views are no longer direct children of UIWindow, press events will be handed to FlutterInputView and thenFlutterViewController. We no longer need to manually forward the event to the engine and let the engine pass that to the view controller, as the super implementation already does that. Plus nextAction also forwards the incoming events to the view controller so that call path is essentially sending the same event to FlutterViewController twice.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label Nov 2, 2021
jmagman
jmagman approved these changes Nov 2, 2021
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman
Copy link
Member

jmagman commented Nov 2, 2021 •
edited
Loading

Actually, test failed:

<unknown>:0: error: -[FlutterTextInputPluginTest testPropagatePressEventsToNextResponder] : Did not record an invocation in OCMStub/OCMExpect/OCMReject.
Possible causes are:
- The receiver is not a mock object.
- The selector conflicts with a selector implemented by OCMStubRecorder/OCMExpectationRecorder. (NSInternalInconsistencyException)
...
Failing tests:
	IosUnitTestsTests:
		-[FlutterTextInputPluginTest testPropagatePressEventsToNextResponder]

gspencergoog
gspencergoog approved these changes Nov 2, 2021
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

Modulo the test failure.

@LongCatIsLooong
Copy link
Contributor Author

LongCatIsLooong commented Nov 2, 2021

Actually, test failed:

<unknown>:0: error: -[FlutterTextInputPluginTest testPropagatePressEventsToNextResponder] : Did not record an invocation in OCMStub/OCMExpect/OCMReject.
Possible causes are:
- The receiver is not a mock object.
- The selector conflicts with a selector implemented by OCMStubRecorder/OCMExpectationRecorder. (NSInternalInconsistencyException)
...
Failing tests:
	IosUnitTestsTests:
		-[FlutterTextInputPluginTest testPropagatePressEventsToNextResponder]

I noticed my tests are not re-compiled after I changed the code (I renamed the test and then recompiled & rerun it, the output still showed the old name of the test). I did recompile the ios_test_flutter target before running ./run_tests.py --type=objc. What am I missing?

@LongCatIsLooong LongCatIsLooong force-pushed the dont-forward-keyevents-to-engine branch from 64453e8 to 8356237 Compare November 2, 2021 16:53
@LongCatIsLooong LongCatIsLooong added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Nov 2, 2021
@fluttergithubbot fluttergithubbot merged commit 11b553b into flutter:master Nov 2, 2021
@LongCatIsLooong LongCatIsLooong deleted the dont-forward-keyevents-to-engine branch November 2, 2021 18:02
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 2, 2021
@engine-flutter-autoroll
11b553b [iOS text input] do not forward press events to the engine (f…
78d78a8 
…lutter/engine#29464)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 3, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 3, 2021
@engine-flutter-autoroll
11b553b [iOS text input] do not forward press events to the engine (f…
6249642 
…lutter/engine#29464)
@TahaTesser TahaTesser mentioned this pull request Nov 24, 2021
Closed
godofredoc added a commit that referenced this pull request Dec 1, 2021
@godofredoc @LongCatIsLooong
[iOS text input] do not forward press events to the engine (#29464) (#…
06a7363 
…30037)

Co-authored-by: LongCatIsLooong <[email protected]>
@jmagman jmagman mentioned this pull request Dec 8, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@jmagman jmagman jmagman approved these changes

@gspencergoog gspencergoog gspencergoog approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes platform-ios waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[iOS][Simulator]: Trying to toggle software keyboard throws unhandled exception on latest master and beta

4 participants

@LongCatIsLooong @jmagman @gspencergoog @fluttergithubbot