[web] Fail if Skia Gold is required but unavailable#29792
[web] Fail if Skia Gold is required but unavailable#29792fluttergithubbot merged 2 commits intoflutter:mainfrom
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Gold has detected about 58 new digest(s) on patchset 1. |
| ); | ||
| argParser.addFlag( | ||
| 'require-skia-gold', | ||
| defaultsTo: false, |
There was a problem hiding this comment.
I would default this to true. If that's not possible in this PR, then in a follow-up PR. The reason is that it's too easy to forget to set this flag, and I don't just mean when running felt manually, but in recipes and tools where we find logic that leads to false positives more often than we should. Here are some examples of past P0s and P1s that were caused because our code forgot to opt into failing tests:
There was a problem hiding this comment.
But we don't want to make it true for local testing, right? Do you suggest we only enforce it in CI?
mdebbar
added
the
waiting for tree to go green
4 participants
As a follow up to #29139, this PR fails tests if Skia Gold was expected to run but wasn't available.
This PR just adds the
--require-skia-goldflag tofelt. There's also a change in recipes to start passing this flag: