This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Embedder] Send key data through message channel#29795
Merged
dkwingsmt merged 11 commits intoflutter:mainfrom Nov 19, 2021
Merged
[Embedder] Send key data through message channel#29795dkwingsmt merged 11 commits intoflutter:mainfrom
dkwingsmt merged 11 commits intoflutter:mainfrom
Conversation
dnfield
reviewed
Nov 18, 2021
dnfield
approved these changes
Nov 18, 2021
Co-authored-by: Dan Field <[email protected]>
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 19, 2021
This was referenced May 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes how embedder API's
SendKeyDatasendsui.KeyDatato the framework. This is a reland of #29638, which somehow became empty possibly due to the recent switch frommastertomain.Currently the packet is sent over FFI through a series of
DispatchKeyDatamethods that drill all the way fromWindowtoEmbedderEngine. Not only is it cumbersome, but it also bypasses the existing buffering mechanism, leading to a crash as described in flutter/flutter#89748 (comment).This PR changes the packet to be sent over the existing platform messenger, reusing the entirety of its code path and functionalities while keeping the embedder API unchanged.
This partially fixes flutter/flutter#89748 (comment). Since the buffer size is only 1, if 2 or more events are sent during the restart (which usually means holding multiple keys) the crash will still occur. There's a way to resize the buffer, but I haven't found a way to actually do it yet, and will explore as the next step.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.