[Proposal] Improve Canvas Documentation#30069
Conversation
The following suggestions. flutter/flutter#93190 For clarity, the text has been improved over when it was suggested.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
There are 2 constructors for Vertices, the second one |
|
Hi @flar, |
|
@MasahideMori-SimpleAppli it's the same data, just packed into a few raw typed data lists that can be shared directly with the native implementation. the constructor you documented simply converts its Dart lists into typed arrays before it calls to the native init method whereas the raw constructor can dive directly into the native init. It's easier for developers to work with dart List objects of flutter classes then the typed lists of basic numerical values, but the latter is faster for getting the data down to C++ for handing off to Skia. |
|
Hi @flar, |
The following suggestions. For clarity, the text has been improved over when it was suggested.
flutter/flutter#93190
I'm not a native English speaker, so I'm sorry if it's strange English.
If there is a mistake in the English grammar I wrote, it is difficult for me to correct it.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.