This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Remove usage of flutter/goldens#30116
Merged
mdebbar merged 2 commits intoflutter:mainfrom Jan 24, 2022
Merged
Conversation
6 tasks
mdebbar
force-pushed
the
remove_goldens_repo
branch
from
d5ac907 to
e880f35
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 24, 2022
jason-simmons
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 24, 2022
* 016f458 Roll Skia from 67f92df4b059 to b894b0594eee (1 revision) (flutter/engine#31019) * 83cfdcc [web] Remove usage of flutter/goldens (flutter/engine#30116)
clocksmith
pushed a commit
to clocksmith/flutter
that referenced
this pull request
Mar 8, 2022
* 016f458 Roll Skia from 67f92df4b059 to b894b0594eee (1 revision) (flutter/engine#31019) * 83cfdcc [web] Remove usage of flutter/goldens (flutter/engine#30116)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that engine PRs are uploading images to Gold, and the
flutter-goldcheck is being applied to them correctly, we don't need the flutter/golden repo anymore.This PR stops using the flutter/goldens repo in the web engine.
Next step would be to archive the flutter/goldens repo.