This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Conversation
This reverts commit 46d365a.
zanderso
deleted the
revert-30152-dart-sdk-flutter-engine-ea6f6e89-d170-4be5-aea9-02d5bd95c474-1638772034
branch
Contributor
|
I presume the reason for the review is the Dart SDK G3 roll hasn't happened yet. This morning in the VM team meeting folks were wondering if picking the engine version that has the Dart version 68bd330 as the version which will be branched by the engine. |
Member
Author
|
Good point. I've requested an Engine -> Framework roll to the commit before the Dart roll that this PR reverts. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 8, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #30152
Reverting for g3 branch alignment.