Conversation
"Observatory listening on..." is eventually being updated to "Dart VM Service listening on...". This change allows for parsing the VM service URI from messages of either format. See dart-lang/sdk#46756
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
@jason-simmons @chinmaygarde, I think these are the only places in the engine repo that actually look for the "Observatory listening on" string. Please let me know if I missed any other instances, thanks! |
2 participants
"Observatory listening on..." is eventually being updated to "Dart VM
Service listening on...". This change allows for parsing the VM service
URI from messages of either format.
See dart-lang/sdk#46756