Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Change support for VM service message from "Dart VM Service listening" to "The Dart VM Service is listening"#31310

Merged
bkonyi merged 1 commit intomainfrom
handle_new_vm_service_msg_take2
Feb 7, 2022
Merged

Change support for VM service message from "Dart VM Service listening" to "The Dart VM Service is listening"#31310
bkonyi merged 1 commit intomainfrom
handle_new_vm_service_msg_take2

Conversation

@bkonyi
Copy link
Contributor

@bkonyi bkonyi commented Feb 7, 2022

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@bkonyi bkonyi merged commit 5df3d0e into main Feb 7, 2022
@bkonyi bkonyi deleted the handle_new_vm_service_msg_take2 branch February 7, 2022 21:55
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants