This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Conversation
This reverts commit 9968a9f.
gaaclarke
approved these changes
Feb 8, 2022
gaaclarke
added
the
waiting for tree to go green
zanderso
deleted the
revert-31327-dart-sdk-flutter-engine-056b0844-c17a-45c5-853c-55fcb706b796-1644329895
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 8, 2022
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Feb 9, 2022
This reverts commit 7bb6841. Reason for revert: Flutter rolls are failing, please see flutter/engine#31332 Original change's description: > Reland "Remove the pub top-level" > > This is a reland of 872ffa8 > > Original change's description: > > Remove the pub top-level > > > > The old pub toplevel interface is still reachable via > > > > ``` > > $ dart __deprecated_pub > > ``` > > > > That is what `flutter pub` is using. > > > > Part of #46100 > > > > Bug: dart-lang/pub#3292 > > Change-Id: I97a14f2458d0f67c7bf98a90664d504cfaba0e98 > > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/229541 > > Reviewed-by: Jonas Jensen <[email protected]> > > Reviewed-by: Michael Thomsen <[email protected]> > > Commit-Queue: Sigurd Meldgaard <[email protected]> > > Bug: dart-lang/pub#3292 > Change-Id: I45b5bf93f30c8abad4558cb15b61289c6c786f65 > Cq-Include-Trybots: luci.dart.try:flutter-engine-linux-try,flutter-engine-linux-web_tests-try,flutter-frontend-try > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231943 > Reviewed-by: Jonas Jensen <[email protected]> > Reviewed-by: Michael Thomsen <[email protected]> > Commit-Queue: Sigurd Meldgaard <[email protected]> # Not skipping CQ checks because original CL landed > 1 day ago. Bug: dart-lang/pub#3292 Change-Id: Ie64d894efac2b5d686f470e2465819c74dd917ff Cq-Include-Trybots: luci.dart.try:flutter-engine-linux-try,flutter-engine-linux-web_tests-try,flutter-frontend-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232131 Reviewed-by: Siva Annamalai <[email protected]> Reviewed-by: Ben Konyi <[email protected]> Commit-Queue: Siva Annamalai <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #31327
Framework LUCI recipes still refer to pub. See the failures on the Engine roll here: flutter/flutter#98056
/cc @gaaclarke The Sheriff
/cc @sigurdm
/cc @a-siva