This repository was archived by the owner on Feb 25, 2025. It is now read-only.
De-flake CanCreateShellsWithMetalBackend#31343
Merged
bdero merged 1 commit intoflutter:mainfrom Feb 9, 2022
Merged
Conversation
zanderso
approved these changes
Feb 9, 2022
Member
zanderso
left a comment
zanderso
left a comment
There was a problem hiding this comment.
I don't have a good suggestion for erecting guardrails. I only have a so-so suggestion: Maybe require passing a RunConfiguration to PlatformViewNotifyCreated?
Contributor
Author
|
Hmm, it looks like there are some tests that call |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#96807.
The race:
RunConfigurationconstructor assignsPersistentCache::asset_manager_(global state).PersistentCache::asset_manager_.The behavior of the callback itself doesn't seem unreasonable to me, but we can probably add a seatbelt to this test harness to prevent this kind of thing in the future.