Fix initialization of ThreadHost name prefix#31420
Fix initialization of ThreadHost name prefix#31420fluttergithubbot merged 1 commit intoflutter:mainfrom
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
gaaclarke
left a comment
gaaclarke
left a comment
There was a problem hiding this comment.
lgtm modulo test and a nit about not using an initializer
shell/common/thread_host.cc
Outdated
| : ThreadHost(ThreadHostConfig(name_prefix, mask)) {} | ||
|
|
||
| ThreadHost::ThreadHost(const ThreadHostConfig& host_config) { | ||
| name_prefix = host_config.name_prefix; |
shell/common/thread_host.cc
Outdated
| : ThreadHost(ThreadHostConfig(name_prefix, mask)) {} | ||
|
|
||
| ThreadHost::ThreadHost(const ThreadHostConfig& host_config) { | ||
| name_prefix = host_config.name_prefix; |
There was a problem hiding this comment.
This should be easy to test hopefully.
jason-simmons
force-pushed
the
ios_thread_host_prefix
branch
from
942d557 to
944c153
Compare
jason-simmons
force-pushed
the
ios_thread_host_prefix
branch
from
944c153 to
b0b05d9
Compare
jason-simmons
added
the
waiting for tree to go green
3 participants
No description provided.