This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Skip font-tests for host_profile variants.#31515
Merged
zanderso merged 1 commit intoflutter:mainfrom Feb 17, 2022
godofredoc:skip_fonttest
Merged
Skip font-tests for host_profile variants.#31515zanderso merged 1 commit intoflutter:mainfrom godofredoc:skip_fonttest
zanderso merged 1 commit intoflutter:mainfrom
godofredoc:skip_fonttest
Conversation
font-tests are not built by default in the host_profile variant. The test was working properly because all the variants were being built sequentially in the same host. With the separation of builds and tests every variant is built in a separate host and host_profile does not have access to font-tests built by host_debug. Bug: flutter/flutter#98642
zanderso
approved these changes
Feb 17, 2022
Member
|
Filed flutter/flutter#98674 for the disagreement between cocoon/the github check and LUCI. Landing manually. |
Contributor
Author
|
By the way this is how Linux Host Engine will look like after separating builds from tests: https://chromium-swarm.appspot.com/task?id=5921735ebb5b9210 |
Member
Nice |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
font-tests are not built by default in the host_profile variant. The
test was working properly because all the variants were being built
sequentially in the same host. With the separation of builds and tests
every variant is built in a separate host and host_profile does not have
access to font-tests built by host_debug.
Bug: flutter/flutter#98642
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.