Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Web: treat modifier key without location (generate key map from flutter/flutter#98460)#31550

Merged
dkwingsmt merged 1 commit intoflutter:mainfrom
moko256:moko256_web_map_no_location_key_gen_test
Mar 7, 2022
Merged

Web: treat modifier key without location (generate key map from flutter/flutter#98460)#31550
dkwingsmt merged 1 commit intoflutter:mainfrom
moko256:moko256_web_map_no_location_key_gen_test

Conversation

@moko256
Copy link
Contributor

@moko256 moko256 commented Feb 18, 2022

Re-generate lib\web_ui\lib\src\engine\key_map.dart by the changes from flutter/flutter#98460, and add test for flutter/flutter#98460.

Framework PR: flutter/flutter#98460

No changes in flutter/tests.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Feb 18, 2022
@moko256 moko256 mentioned this pull request Feb 18, 2022
Merged
8 tasks
@moko256 moko256 marked this pull request as draft February 18, 2022 18:24
@flutter-dashboard
Copy link

flutter-dashboard bot commented Feb 18, 2022

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

moko256
moko256 commented Feb 18, 2022
View reviewed changes
@moko256 moko256 marked this pull request as ready for review February 18, 2022 18:42
dkwingsmt
dkwingsmt approved these changes Mar 4, 2022
View reviewed changes
Copy link
Contributor

@dkwingsmt dkwingsmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dkwingsmt
Copy link
Contributor

dkwingsmt commented Mar 5, 2022

@mdebbar Can you make a second review?

@dkwingsmt dkwingsmt requested review from mdebbar and yjbanov March 5, 2022 02:05
mdebbar
mdebbar approved these changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@mdebbar mdebbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dkwingsmt dkwingsmt merged commit 12bb741 into flutter:main Mar 7, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 7, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 7, 2022
@engine-flutter-autoroll
12bb741 Web: treat modifier key without location (generate key map from
42ae54c 
flutter#98460) (flutter/engine#31550)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@yjbanov yjbanov Awaiting requested review from yjbanov

2 more reviewers

@mdebbar mdebbar mdebbar approved these changes

@dkwingsmt dkwingsmt dkwingsmt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

platform-web Code specifically for the web engine

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@moko256 @dkwingsmt @mdebbar