Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

GN targets to create flutter_web_sdk.#31556

Merged
fluttergithubbot merged 2 commits intoflutter:mainfrom
godofredoc:gn_web_engine
Feb 20, 2022
Merged

GN targets to create flutter_web_sdk.#31556
fluttergithubbot merged 2 commits intoflutter:mainfrom
godofredoc:gn_web_engine

Conversation

@godofredoc
Copy link
Contributor

@godofredoc godofredoc commented Feb 18, 2022

This is required to separate the the linux builds and tests.

Bug: flutter/flutter#81855

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
GN targets to create flutter_web_sdk.
19065b2 
This is required to separate the the linux builds and tests.

Bug: flutter/flutter#81855
@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Feb 18, 2022
zanderso
zanderso reviewed Feb 18, 2022
View reviewed changes
web_sdk/BUILD.gn Outdated

# Archives Flutter Web SDK
zip_bundle("flutter_web_sdk_archive") {
output = "flutter-web-sdk-${host_os}-${target_cpu}.zip"
Copy link
Member

@zanderso zanderso Feb 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ${host_os}-${target_cpu} combo doesn't make sense. I think you want ${target_os}-${target_cpu}. Not sure why the ${target_cpu} part is included since I think these artifacts are arch generic, but maybe @yjbanov can explain.

If this is going to be coming up more even after this, we could consider making some of the definitions here public: https://github.com/flutter/engine/blob/main/common/config.gni#L87

Copy link
Contributor Author

@godofredoc godofredoc Feb 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are many artifacts for the different platforms that are using ${target_os}-${target_cpu} in their names. I'll go ahead and make the definition you pointed out public.

@godofredoc godofredoc requested a review from yjbanov February 19, 2022 00:43
@godofredoc godofredoc added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Feb 20, 2022
@fluttergithubbot fluttergithubbot merged commit f7f0159 into flutter:main Feb 20, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 20, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 20, 2022
@engine-flutter-autoroll
f7f0159 GN targets to create flutter_web_sdk. (flutter/engine#31556)
db2e433
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 20, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 20, 2022
@engine-flutter-autoroll
f7f0159 GN targets to create flutter_web_sdk. (flutter/engine#31556)
22f7299
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 20, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 20, 2022
@engine-flutter-autoroll
f7f0159 GN targets to create flutter_web_sdk. (flutter/engine#31556)
ece0af9
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 20, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 20, 2022
@engine-flutter-autoroll
f7f0159 GN targets to create flutter_web_sdk. (flutter/engine#31556)
ac42d69
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 20, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 20, 2022
@engine-flutter-autoroll
f7f0159 GN targets to create flutter_web_sdk. (flutter/engine#31556)
c4fecb2
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 20, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 20, 2022
@engine-flutter-autoroll
f7f0159 GN targets to create flutter_web_sdk. (flutter/engine#31556)
55f1ec5
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 20, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 20, 2022
@engine-flutter-autoroll
f7f0159 GN targets to create flutter_web_sdk. (flutter/engine#31556)
775b25c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 21, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 21, 2022
@engine-flutter-autoroll
f7f0159 GN targets to create flutter_web_sdk. (flutter/engine#31556)
21be0d9
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 21, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 21, 2022
@engine-flutter-autoroll
f7f0159 GN targets to create flutter_web_sdk. (flutter/engine#31556)
046d30c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 21, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 21, 2022
@engine-flutter-autoroll
f7f0159 GN targets to create flutter_web_sdk. (flutter/engine#31556)
4c12d39
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 21, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 21, 2022
@engine-flutter-autoroll
f7f0159 GN targets to create flutter_web_sdk. (flutter/engine#31556)
204864d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 21, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 21, 2022
@engine-flutter-autoroll
f7f0159 GN targets to create flutter_web_sdk. (flutter/engine#31556)
02c2307
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 21, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 21, 2022
@engine-flutter-autoroll
f7f0159 GN targets to create flutter_web_sdk. (flutter/engine#31556)
1e16b74
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 21, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 21, 2022
@engine-flutter-autoroll
f7f0159 GN targets to create flutter_web_sdk. (flutter/engine#31556)
f2ca382
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 21, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 21, 2022
@engine-flutter-autoroll
f7f0159 GN targets to create flutter_web_sdk. (flutter/engine#31556)
be8c11f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 21, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 21, 2022
@engine-flutter-autoroll
f7f0159 GN targets to create flutter_web_sdk. (flutter/engine#31556)
15f0a36
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 22, 2022
@engine-flutter-autoroll
f7f0159 GN targets to create flutter_web_sdk. (flutter/engine#31556)
6eac1bd
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 22, 2022
@engine-flutter-autoroll
f7f0159 GN targets to create flutter_web_sdk. (flutter/engine#31556)
726d599
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 22, 2022
@engine-flutter-autoroll
f7f0159 GN targets to create flutter_web_sdk. (flutter/engine#31556)
998fb04
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 22, 2022
@engine-flutter-autoroll
f7f0159 GN targets to create flutter_web_sdk. (flutter/engine#31556)
dc2cb49
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 22, 2022
@engine-flutter-autoroll
f7f0159 GN targets to create flutter_web_sdk. (flutter/engine#31556)
31a2e5e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 22, 2022
@engine-flutter-autoroll
f7f0159 GN targets to create flutter_web_sdk. (flutter/engine#31556)
09bdd40
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 22, 2022
@engine-flutter-autoroll
f7f0159 GN targets to create flutter_web_sdk. (flutter/engine#31556)
089f2ad
CaseyHillers pushed a commit to CaseyHillers/engine that referenced this pull request Feb 25, 2022
@godofredoc
GN targets to create flutter_web_sdk. (flutter#31556)
3914016
@CaseyHillers CaseyHillers mentioned this pull request Feb 25, 2022
Merged
CaseyHillers pushed a commit that referenced this pull request Feb 25, 2022
@godofredoc
[Cherrypick] Changes related to Build+Test separation (#31682)
373b5e3 
* GN targets to create flutter_web_sdk. (#31556)

* Fix gn problem impacting fuchsia builds. (#31615)

* Generate fonts in the expected location. (#31575)

* Generate fonts in the expected location.

Fonts-subset is generated directly in out/../zip_archives but the final
destination is expected to be inside a folder like linux-x64. This PR
generates the file directly in the expected path.

Bug: flutter/flutter#81855

* Fix font zip tests.

* Revert changes to run_tests.py

* Update host_os_cpu_name variable to report darwin for mac.

* Fix variable names.

* Calculate prebuilts path using mac instead of darwin.

* Add platform to fontset path.

* Fix platforms map.

* Add debugging.

* Add win32 to the map of artifact locations.

* Use full_platform_name instead of host_os_name.

* Use x32 for windows font binaries.

* Fix paths for debug version in windows.

* Use x64 for win32.

* Remove additional logging.

* Add linux2 to map of platforms.

Co-authored-by: godofredoc <[email protected]>
@godofredoc godofredoc deleted the gn_web_engine branch January 12, 2024 19:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dnfield dnfield Awaiting requested review from dnfield

@yjbanov yjbanov Awaiting requested review from yjbanov

1 more reviewer

@zanderso zanderso zanderso approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

platform-web Code specifically for the web engine waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@godofredoc @zanderso @fluttergithubbot