This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Tweak drawTextBlob cost based on multiple draw calls and update the benchmark accordingly#31561
Merged
gw280 merged 1 commit intoflutter:mainfrom Feb 19, 2022
Merged
Conversation
…enchmark accordingly
zanderso
approved these changes
Feb 19, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 19, 2022
…te the benchmark accordingly (flutter/engine#31561)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out that with drawTextBlob it's more important to consider the number of times it was called during a single frame rather than the number of glyphs in the drawTextBlob. This seems to be because drawTextBlob calls are deferred and batched if possible, thus we only pay the (high) upfront cost once or a few times instead of every time.
This tweaks the benchmark so that we are measuring the impact of multiple drawTextBlob calls, and also updates the calculators to use data gathered from the new benchmark instead. This also involved a minor refactoring to better cater to "batched complexities" like saveLayer and drawTextBlob.
There is more work to be done here, at a minimum we'd need to consider the following:
Pre-launch Checklist
writing and running engine tests.
///).