Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Run mac web engine in recipes cq#31623

Merged
godofredoc merged 1 commit intoflutter:mainfrom
godofredoc:ensure_cq
Feb 23, 2022
Merged

Run mac web engine in recipes cq#31623
godofredoc merged 1 commit intoflutter:mainfrom
godofredoc:ensure_cq

Conversation

@godofredoc
Copy link
Contributor

@godofredoc godofredoc commented Feb 23, 2022

Run Mac Web Engine in the recipe cq tests to ensure the functionality is not brocken on changes to recipe modules.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
Enable Mac Web Engine in recipes tests.
a1e1000 
This is required to test this builder on the recipes changes.
keyonghan
keyonghan approved these changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@godofredoc godofredoc merged commit 258e7ff into flutter:main Feb 23, 2022
@godofredoc godofredoc deleted the ensure_cq branch February 23, 2022 04:49
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 23, 2022
@engine-flutter-autoroll
258e7ff Enable Mac Web Engine in recipes tests. (flutter/engine#31623)
d5c91de
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@CaseyHillers CaseyHillers Awaiting requested review from CaseyHillers

1 more reviewer

@keyonghan keyonghan keyonghan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@godofredoc @keyonghan