This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Generate linux gtk zip in the correct folder.#31650
Merged
fluttergithubbot merged 2 commits intoflutter:mainfrom Feb 24, 2022
godofredoc:create_gtk_correct_folder
Merged
Generate linux gtk zip in the correct folder.#31650fluttergithubbot merged 2 commits intoflutter:mainfrom godofredoc:create_gtk_correct_folder
fluttergithubbot merged 2 commits intoflutter:mainfrom
godofredoc:create_gtk_correct_folder
Conversation
The GTK files are expected in different folders depending on the platform. This change ensures the zip file are created in the correct folders. Bug: flutter/flutter#81855
Contributor
Author
|
Full build with dependencies is now complete https://chromium-swarm.appspot.com/task?id=5943b1aaeadc7110. It takes 10 mins in total but I think we can optimize it more. Would it make sense to separate the unit tests to their own target? |
dnfield
approved these changes
Feb 24, 2022
godofredoc
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GTK files are expected in different folders depending on the
platform. This change ensures the zip file are created in the correct
folders.
Bug: flutter/flutter#81855
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.