Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Separate unittest to its own group.#31789

Merged
fluttergithubbot merged 1 commit intoflutter:mainfrom
godofredoc:separate_unittests
Mar 3, 2022
Merged

Separate unittest to its own group.#31789
fluttergithubbot merged 1 commit intoflutter:mainfrom
godofredoc:separate_unittests

Conversation

@godofredoc
Copy link
Contributor

@godofredoc godofredoc commented Mar 3, 2022

This will allow us to optimize builds by explicitly calling only the targets
that are required.

Bug: flutter/flutter#81855

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
Separate unittest to its own group.
995cbe3 
This will allow us to optimize builds by explicitly calling only the targets
that are required.

Bug: flutter/flutter#81855
@godofredoc godofredoc requested review from dnfield and zanderso March 3, 2022 05:43
@godofredoc godofredoc added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Mar 3, 2022
@fluttergithubbot fluttergithubbot merged commit c4b3af8 into flutter:main Mar 3, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 3, 2022
@engine-flutter-autoroll
c4b3af8 Separate unittest to its own group. (flutter/engine#31789)
bad59b9
@godofredoc godofredoc deleted the separate_unittests branch January 12, 2024 19:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@zanderso zanderso Awaiting requested review from zanderso

1 more reviewer

@dnfield dnfield dnfield approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@godofredoc @dnfield @fluttergithubbot