This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix mac_ios_builder.#31790
Merged
godofredoc merged 1 commit intoflutter:mainfrom Mar 3, 2022
godofredoc:fix_mac_ios_engine
Merged
Fix mac_ios_builder.#31790godofredoc merged 1 commit intoflutter:mainfrom godofredoc:fix_mac_ios_engine
godofredoc merged 1 commit intoflutter:mainfrom
godofredoc:fix_mac_ios_engine
Conversation
This has been running only on staging but has always been failing because is missing the jazzy dependency.
godofredoc
commented
Mar 3, 2022
| properties: | ||
| config_name: mac_ios_engine | ||
| environment: Staging | ||
| dependencies: >- |
Contributor
Author
There was a problem hiding this comment.
@CaseyHillers does this overrides the property or expands it?
Contributor
There was a problem hiding this comment.
This extends it. If the platform defines jazzy with a version, this will do nothing.
So if you want Mac dependencies + jazzy, this is the correct change.
Contributor
Author
There was a problem hiding this comment.
Yes, that's what I was looking for. Thanks!
CaseyHillers
approved these changes
Mar 3, 2022
| properties: | ||
| config_name: mac_ios_engine | ||
| environment: Staging | ||
| dependencies: >- |
Contributor
There was a problem hiding this comment.
This extends it. If the platform defines jazzy with a version, this will do nothing.
So if you want Mac dependencies + jazzy, this is the correct change.
godofredoc
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 3, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 3, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been running only on staging but has always been failing
because is missing the jazzy dependency.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.