This repository was archived by the owner on Feb 25, 2025. It is now read-only.
iOS removes children references when semantics node is replaced#31810
Merged
fluttergithubbot merged 1 commit intoflutter:mainfrom Mar 4, 2022
Merged
iOS removes children references when semantics node is replaced#31810fluttergithubbot merged 1 commit intoflutter:mainfrom
fluttergithubbot merged 1 commit intoflutter:mainfrom
Conversation
chunhtai
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 4, 2022
godofredoc
added a commit
that referenced
this pull request
Mar 15, 2022
* iOS removes children references when semantics node is replaced (#31810) * Update licenses hash. * Update .cirrus envs. Co-authored-by: chunhtai <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The oldObject still holds its children reference after the ReplaceSemanticsObject, which causes the oldObject to clean up those children's parents relationship when it deallocated. This pr fixes it so it remove the reference to it children when the oldObject is replaced since the lifecycle of the children should belong to the newObject after this point.
fixes flutter/flutter#99440
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.