Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Adding archives to the windows host engine.#31821

Merged
fluttergithubbot merged 3 commits intoflutter:mainfrom
godofredoc:add_windows
Mar 4, 2022
Merged

Adding archives to the windows host engine.#31821
fluttergithubbot merged 3 commits intoflutter:mainfrom
godofredoc:add_windows

Conversation

@godofredoc
Copy link
Contributor

@godofredoc godofredoc commented Mar 4, 2022 •
edited
Loading

This is to complete the implementation of windows host engine separating builds from tests.

Bug: flutter/flutter#81855

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
Adding archives to the windows host engine.
971ee42 
This is a step forward to move the engine_v2 builds to prod which will
split tests from builds.

Bug: flutter/flutter#81855
@godofredoc
Build unittest target instead of flutter.
8d30b3d
@godofredoc
Fix unittests target.
093aac1
@godofredoc godofredoc requested review from dnfield and zanderso March 4, 2022 06:50
@godofredoc godofredoc added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Mar 4, 2022
@fluttergithubbot fluttergithubbot merged commit ff6f547 into flutter:main Mar 4, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 4, 2022
@engine-flutter-autoroll
ff6f547 Adding archives to the windows host engine. (flutter/engine#3…
40029d4 
…1821)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 4, 2022
@engine-flutter-autoroll
ff6f547 Adding archives to the windows host engine. (flutter/engine#3…
0b0ab73 
…1821)
zanderso
zanderso reviewed Mar 4, 2022
View reviewed changes
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@godofredoc godofredoc deleted the add_windows branch January 12, 2024 19:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@zanderso zanderso zanderso left review comments

@dnfield dnfield dnfield approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@godofredoc @zanderso @dnfield @fluttergithubbot