Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Win32, Keyboard] Fix AltGr's forged ControlLeft#31848

Merged
fluttergithubbot merged 1 commit intoflutter:mainfrom
dkwingsmt:fix-altgr-lcontrol
Mar 9, 2022
Merged

[Win32, Keyboard] Fix AltGr's forged ControlLeft#31848
fluttergithubbot merged 1 commit intoflutter:mainfrom
dkwingsmt:fix-altgr-lcontrol

Conversation

@dkwingsmt
Copy link
Contributor

@dkwingsmt dkwingsmt commented Mar 5, 2022

This PR fixes flutter/flutter#98071, where pressing AltGr while CtrlLeft is held causes crash.

Flutter forges a ControlLeft keyup when AltGr is released, but since Flutter Win32 used to use SendInput to forge events, it sends VK_LCONTROL as virtual key, despite that the original event uses VK_CONTROL. Now that it has switched to SendMessage, it must use the exact VK.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@dkwingsmt dkwingsmt added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Mar 8, 2022
@fluttergithubbot fluttergithubbot merged commit fe3ecd7 into flutter:main Mar 9, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

platform-windows waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Windows Desktop] A KeyUpEvent is dispatched, but the state shows that the physical key is not pressed.

3 participants