This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Use config to set land qualifiers#31853
Merged
zanderso merged 1 commit intoflutter:mainfrom Mar 9, 2022
utzcoz:improve-robolectric-tests
Merged
Use config to set land qualifiers#31853zanderso merged 1 commit intoflutter:mainfrom utzcoz:improve-robolectric-tests
zanderso merged 1 commit intoflutter:mainfrom
utzcoz:improve-robolectric-tests
Conversation
Signed-off-by: utzcoz <[email protected]>
Contributor
Author
|
Hi @zanderso, could you help to review this PR? Looks like luci-engine job failed because of broken tree. Thanks. |
Member
|
Please add more details to the PR description and/or link to the github issue that this solves. |
Contributor
Author
I have updated PR description with extra link. |
blasten
added
the
waiting for tree to go green
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
fluttergithubbot
removed
the
waiting for tree to go green
|
@jason-simmons It needs your approval |
Contributor
Author
Friendly ping @jason-simmons , could you help to review this PR? Thanks. |
zanderso
approved these changes
Mar 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-launch Checklist
writing and running engine tests.
///).This PR uses
qualifiersinConfig(http://robolectric.org/using-qualifiers/) of Robolectric to set landscape resource qualifier to replace currentRuntimeEnvironment#setQualifierscalling. This replacing can help to improve the introductoryness of the test code.