Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fixs impeller_enable_playground is invalid variable when compiling the engine#31871

Merged
fluttergithubbot merged 5 commits intoflutter:mainfrom
linxuebin1990:impeller_enable_playground_3
Mar 10, 2022
Merged

Fixs impeller_enable_playground is invalid variable when compiling the engine#31871
fluttergithubbot merged 5 commits intoflutter:mainfrom
linxuebin1990:impeller_enable_playground_3

Conversation

@linxuebin1990
Copy link
Member

@linxuebin1990 linxuebin1990 commented Mar 7, 2022

fix impeller_enable_playground is invalid when build engine, which show in (flutter/flutter#99670)

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@linxuebin1990
enable impeller_enable_playground only when target_os is mac
0197c22 
enable impeller_enable_playground only when target_os is mac
@linxuebin1990
Copy link
Member Author

linxuebin1990 commented Mar 7, 2022

/cc @zanderso

zanderso
zanderso reviewed Mar 7, 2022
View reviewed changes
@linxuebin1990
set impeller_enable_playground value，When external parameters are pas…
d4900f5 
…sed in

set impeller_enable_playground value，When external parameters are passed in
@linxuebin1990 linxuebin1990 changed the title enable impeller_enable_playground only when target_os is mac Fixs impeller_enable_playground is invalid variable when compiling the engine Mar 8, 2022
@zanderso zanderso added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Mar 8, 2022
@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Mar 8, 2022

This pull request is not suitable for automatic merging in its current state.

  • Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Mar 8, 2022
@eggfly eggfly added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Mar 9, 2022
@fluttergithubbot fluttergithubbot merged commit 1befbdd into flutter:main Mar 10, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 10, 2022
@engine-flutter-autoroll
1befbdd Fixs impeller_enable_playground is invalid variable when comp…
c69451a 
…iling the engine (flutter/engine#31871)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@eggfly eggfly eggfly approved these changes

@zanderso zanderso zanderso approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@linxuebin1990 @fluttergithubbot @eggfly @zanderso