Allow providing max_cache_entry flag to Dart#31881
Allow providing max_cache_entry flag to Dart#31881fluttergithubbot merged 3 commits intoflutter:mainfrom
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
@zanderso I don't believe we ever test these, but I'm unsure of what the usual justification is |
|
I think the test might be here https://github.com/flutter/engine/blob/main/shell%2Fcommon%2Fshell_unittests.cc#L522 |
|
even better, thanks! |
jonahwilliams
added
waiting for tree to go green
3 participants
This flag is used to increase/decrease the size of the type check cache in native dart applications. This can be used to simulate the impact of running in an application that has many more subtypes of widget than a simple benchmark. This will allow us to determine whether it is worth making element generic to remove additional type checks