Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[windows] Add dia_dll version for VS2022.#31890

Merged
fluttergithubbot merged 1 commit intomainfrom
support_vs2022
Mar 10, 2022
Merged

[windows] Add dia_dll version for VS2022.#31890
fluttergithubbot merged 1 commit intomainfrom
support_vs2022

Conversation

@eggfly
Copy link
Member

@eggfly eggfly commented Mar 8, 2022

Fixes:

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

@eggfly eggfly requested review from dnfield and gaaclarke March 8, 2022 08:35
dnfield
dnfield reviewed Mar 8, 2022
View reviewed changes
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM.

@cbracken @jonahwilliams both do engine dev in Windows more than I and may want to verify.

@dnfield dnfield added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Mar 8, 2022
@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Mar 8, 2022

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Windows Host Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Windows UWP Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Mar 8, 2022
cbracken
cbracken approved these changes Mar 8, 2022
View reviewed changes
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM stamp from a Japanese personal seal

@cbracken cbracken added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Mar 8, 2022
@eggfly eggfly changed the title (windows) Add dia_dll version for VS2022. [windows] Add dia_dll version for VS2022. Mar 9, 2022
@fluttergithubbot fluttergithubbot merged commit 0c9a984 into main Mar 10, 2022
@zanderso zanderso deleted the support_vs2022 branch March 10, 2022 06:54
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 10, 2022
@engine-flutter-autoroll
0c9a984 [windows] Add dia_dll version for VS2022. (flutter/engine#31890)
207ec7a
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@gaaclarke gaaclarke Awaiting requested review from gaaclarke

2 more reviewers

@cbracken cbracken cbracken approved these changes

@dnfield dnfield dnfield approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eggfly @fluttergithubbot @cbracken @dnfield