This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Generate MacOS framework with GN + Ninja.#31903
Merged
fluttergithubbot merged 6 commits intoflutter:mainfrom Mar 9, 2022
godofredoc:mac_os_flutter
Merged
Generate MacOS framework with GN + Ninja.#31903fluttergithubbot merged 6 commits intoflutter:mainfrom godofredoc:mac_os_flutter
fluttergithubbot merged 6 commits intoflutter:mainfrom
godofredoc:mac_os_flutter
Conversation
zanderso
reviewed
Mar 9, 2022
shell/platform/darwin/macos/BUILD.gn
Outdated
| } | ||
| } | ||
|
|
||
| zip_bundle("_zip_macos_flutter_framework") { |
Member
There was a problem hiding this comment.
If the '_' is meant to communicate something about the visibility of this target, then that would be better accomplished by adding visibility = [ ":*" ].
Contributor
Author
There was a problem hiding this comment.
Done! updated the zip_bundle template to include the visibility.
zanderso
approved these changes
Mar 9, 2022
| script = "//flutter/build/zip.py" | ||
| outputs = [ "$root_build_dir/zip_archives/${invoker.output}" ] | ||
| sources = [] | ||
| forward_variables_from(invoker, [ "visibility" ]) |
Member
There was a problem hiding this comment.
optional nit: the forwards usually come first, and it looks like you could also forward deps.
This is to separate the mac builds from tests and archives. Bug: flutter/flutter#81855
godofredoc
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to separate the mac builds from tests and archives.
Bug: flutter/flutter#81855
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.