Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Linux deltas selection fix#31906

Merged
justinmc merged 2 commits intoflutter:mainfrom
justinmc:linux-delta-selection
Mar 9, 2022
Merged

Linux deltas selection fix#31906
justinmc merged 2 commits intoflutter:mainfrom
justinmc:linux-delta-selection

Conversation

@justinmc
Copy link
Contributor

@justinmc justinmc commented Mar 8, 2022

Fixing a use of composing_range when it should have been selection.

@justinmc justinmc requested a review from cbracken March 8, 2022 21:11
@justinmc justinmc self-assigned this Mar 8, 2022
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@justinmc
Copy link
Contributor Author

justinmc commented Mar 8, 2022

@cbracken Is this the line that you and I were talking about the other day? Sorry it took me awhile to open this. I can't get my new Linux machine to compile the engine so I'm making this change blind...

Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM stamp from a Japanese personal seal

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants