Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

SaveLayerOptions explicit copy operator#31934

Merged
fluttergithubbot merged 1 commit intoflutter:mainfrom
jmagman:copy-SaveLayerOptions
Mar 9, 2022
Merged

SaveLayerOptions explicit copy operator#31934
fluttergithubbot merged 1 commit intoflutter:mainfrom
jmagman:copy-SaveLayerOptions

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Mar 9, 2022

Fixes flutter/flutter#99795

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman self-assigned this Mar 9, 2022
@jmagman jmagman requested a review from flar March 9, 2022 17:58
flar
flar approved these changes Mar 9, 2022
View reviewed changes
Copy link
Contributor

@flar flar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman force-pushed the copy-SaveLayerOptions branch from 6ae6d75 to 29dbcc7 Compare March 9, 2022 20:38
@jmagman jmagman added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Mar 9, 2022
@fluttergithubbot fluttergithubbot merged commit 9d3dc67 into flutter:main Mar 9, 2022
@jmagman jmagman deleted the copy-SaveLayerOptions branch March 9, 2022 21:53
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 10, 2022
@engine-flutter-autoroll
9d3dc67 SaveLayerOptions explicit copy operator (flutter/engine#31934)
b00787b
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@flar flar flar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

error: definition of implicit copy assignment operator for 'SaveLayerOptions' is deprecated because it has a user-declared copy constructor

3 participants

@jmagman @flar @fluttergithubbot